support unregister cluster in karmada

[wulemao]

What type of PR is this?

/kind feature

What this PR does / why we need it:

support unregister cluster in karmada

Which issue(s) this PR fixes:

Part of #5380

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmadactl: support unregister a pull mode cluster

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.39526% with 252 lines in your changes missing coverage. Please review.

Project coverage is 41.50%. Comparing base (e204459) to head (f803efe).
Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/karmadactl/unregister/unregister.go	0.00%	216 Missing ⚠️
pkg/karmadactl/util/cluster.go	0.00%	28 Missing ⚠️
pkg/util/secret.go	0.00%	6 Missing ⚠️
pkg/karmadactl/karmadactl.go	0.00%	1 Missing ⚠️
pkg/karmadactl/unjoin/unjoin.go	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5626      +/-   ##
==========================================
+ Coverage   40.85%   41.50%   +0.64%     
==========================================
  Files         651      655       +4     
  Lines       55259    55741     +482     
==========================================
+ Hits        22577    23136     +559     
+ Misses      31240    31105     -135     
- Partials     1442     1500      +58     

Flag	Coverage Δ
unittests	41.50% <0.39%> (+0.64%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wulemao]

latest test report:

[wulemao]

According to what we communicated offline, pr is updated

@chaosi-zju ready to review

[chaosi-zju]

/lgtm

/cc @zhzhuang-zju @RainbowMango help a look

[karmada-bot]

@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: a, look.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm

/cc @zhzhuang-zju @RainbowMango help a look

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[RainbowMango]

/assign

[wulemao]

updated, latest test result:

is there any more comments?

[wulemao]

updated, thank you for checking again.

[zhzhuang-zju]

thanks~ others LGTM

[RainbowMango]

Just some nits, otherwise LGTM.

[wulemao]

comments fixed, any more comments? @RainbowMango

[RainbowMango]

Generally looks good to me.

[zhzhuang-zju]

karmada/pkg/controllers/certificate/cert_rotation_controller.go

Lines 52 to 60 in 2a4567c

	const (
	// CertRotationControllerName is the controller name that will be used when reporting events.
	CertRotationControllerName = "cert-rotation-controller"
	// SignerName defines the signer name for csr, 'kubernetes.io/kube-apiserver-client-kubelet' can sign the csr automatically
	SignerName = "kubernetes.io/kube-apiserver-client-kubelet"
	// KarmadaKubeconfigName is the name of the secret containing karmada-agent certificate.
	KarmadaKubeconfigName = "karmada-kubeconfig"

@wulemao @chaosi-zju
CertRotationController in karmad-agent will look up and update the secret karmada-kubeconfig, which has been renamed to karmada-agent-config. We can use func getKarmadaAgentConfig to optimize this hard-coded section.

[wulemao]

updated, latest test result:

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment