-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/workflow: unit test job #5647
operator/pkg/workflow: unit test job #5647
Conversation
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @zhzhuang-zju
In this commit, we unit test the job workflow in the operator package on initializing the running data runtime interface and running tasks and subtasks recursively. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
0b5ba01
to
11bd90e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5647 +/- ##
==========================================
+ Coverage 35.19% 36.66% +1.47%
==========================================
Files 645 648 +3
Lines 44869 45079 +210
==========================================
+ Hits 15791 16528 +737
+ Misses 27846 27302 -544
- Partials 1232 1249 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @XiShanYongYe-Chang, @zhzhuang-zju All test cases passed after addressing the feedback :) |
well done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test the job workflow in the operator package on initializing the running data runtime interface and running tasks and subtasks recursively.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: