Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/workflow: unit test job #5647

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test the job workflow in the operator package on initializing the running data runtime interface and running tasks and subtasks recursively.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2024
@mohamedawnallah mohamedawnallah changed the title operator/pkg/workflow: test job operator/pkg/workflow: unit test job Oct 6, 2024
@XiShanYongYe-Chang
Copy link
Member

/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator/pkg/workflow/job_test.go Outdated Show resolved Hide resolved
operator/pkg/workflow/job_test.go Outdated Show resolved Hide resolved
In this commit, we unit test the job workflow in the operator
package on initializing the running data runtime interface and
running tasks and subtasks recursively.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.66%. Comparing base (8cc712f) to head (11bd90e).
Report is 42 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5647      +/-   ##
==========================================
+ Coverage   35.19%   36.66%   +1.47%     
==========================================
  Files         645      648       +3     
  Lines       44869    45079     +210     
==========================================
+ Hits        15791    16528     +737     
+ Misses      27846    27302     -544     
- Partials     1232     1249      +17     
Flag Coverage Δ
unittests 36.66% <ø> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang, @zhzhuang-zju All test cases passed after addressing the feedback :)

@zhzhuang-zju
Copy link
Contributor

well done
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
@karmada-bot karmada-bot merged commit 46d94ec into karmada-io:master Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants