-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmada-operator: add CRDs archive verification to enhance file system robustness #5703
Conversation
9c40360
to
6e3566c
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5703 +/- ##
==========================================
+ Coverage 46.21% 46.28% +0.07%
==========================================
Files 663 663
Lines 54592 54686 +94
==========================================
+ Hits 25230 25314 +84
- Misses 27735 27745 +10
Partials 1627 1627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bc24da3
to
61c1f12
Compare
c178c66
to
a809285
Compare
a809285
to
be0716b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, otherwise LGTM.
be0716b
to
ff72f33
Compare
…m robustness Signed-off-by: zhzhuang-zju <m17799853869@163.com>
ff72f33
to
63590cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
karmada-operator
provides a custom download path for CRDs files. Before processing the files, it's necessary to validate the CRDs archive to enhance system robustness.Check if its file name includes relative paths.
check if the CRDs archive has the expected directory structure.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
karamdactl init
has the same issue, and its enhancement is ongoingDoes this PR introduce a user-facing change?: