-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes incorrect resource model selection #5706
Fixes incorrect resource model selection #5706
Conversation
241a3a6
to
b390f18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5706 +/- ##
==========================================
+ Coverage 39.15% 39.85% +0.70%
==========================================
Files 650 650
Lines 45207 55145 +9938
==========================================
+ Hits 17701 21980 +4279
- Misses 26142 31753 +5611
- Partials 1364 1412 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ased on resource requests. Now only grades that can provide sufficient resources will be selected. Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
b390f18
to
a6679dd
Compare
cc @chaosi-zju |
lgtm |
You're absolutely right /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…5706-upstream-release-1.11 Automated cherry pick of #5706: Fixes an issue where resource model grades were incorrectly
…5706-upstream-release-1.10 Automated cherry pick of #5706: Fixes an issue where resource model grades were incorrectly
…5706-upstream-release-1.9 Automated cherry pick of #5706: Fixes an issue where resource model grades were incorrectly
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Found this issue during the review of documents at karmada-io/website#713 (comment) by @LavredisG.
Given the resource model:
If a Pod request 1 CPU,
grade 1
will be selected.If a Pod request 1.5 CPU,
grade 1
will be ignored as we are not sure it can provide sufficient resources.Does this PR introduce a user-facing change?: