Making a docker container of my fork?

[ChrisNolan]

So I have a fork of the project that I'd like to have my system run off of instead of the 'live' images. I'm really new to the docker side of things but I was trying to just 'build' my version using the 'docker/api/Dockerfile' for example -- but running into issues. I'm wondering what the 'recommended' way to do this is?

One issue is the 'build context' seems to be setup to be from the project root, but the .dockerignore file is in the docker/api/ directory... copying it to root seems to get around some issues -- but then next up 'git' was required by the requirements.txt but that wasn't setup to be installed in the Dockerfile... but then I looked at what git was being used for ... and it was being used to clone the official repo anyway, and not use the local version so that throws the whole idea out the window.

Thoughts? If this is documented already and I've missed it, I'd appreciate a nudge in that direction too.

[danh91]

Hi @ChrisNolan,

I don't think the .dockerignore files are taken in consideration but the multi-steps build ensures that only the required files end up into the final build.

I haven't had the chance to document building docs on how to build custom images, but I recommend looking into the existing scripts and files as a starting point but also ask questions here when you need help.

Concerning the requirements files, note that the OSS build are created using https://github.com/karrioapi/karrio/blob/main/source.requirements.txt with this approach int the build-from-source

karrio/bin/build-server-image-from-source

Lines 7 to 13 in da16f32

	docker build \
	--no-cache \
	-f "${ROOT}/docker/api/Dockerfile" \
	-t karrio/server:$1 \
	"${ROOT}" \
	--build-arg REQUIREMENTS=source.requirements.txt \
	"${@:2}"

The other main https://github.com/karrioapi/karrio/blob/main/requirements.txt file is mostly used for dockerless installation (But would also work for a docker build - probably will need git installed in the docker image or at least in an image layer if you do a multi-steps build)

[ChrisNolan]

Super, thanks for the details. I had realized that the 'requirements.txt' was an 'argument' and we could pass in a different file and had gotten to trying 'requirements.build.txt' but that ended up failing because of a missing module. Using 'source.requirements.txt' instead has worked and I'm off to the races. Seeing 'bin/build-dashboard-image' as well and that is a much easier build just being the next app.

I did need to add a .dockerignore at the root to exclude the .venv -- on my windows machine the symbolic links in there were messing up the build ; I figured the pip installs inside the image would likely be recreating that anyway. At first I had just used the .dockerignore that was in the docker/api/ directory but it excluded the 'source.requirements.txt' so the build failed not being able to find that file.

Cheers

[ChrisNolan]

So additionally, when making the build for the dashboard there were some complications with the way that 'next js' 'bakes in' the environment variables. Turns out it was because i had a .env in my folder doing local development and setting the localhost:5002 -- this was getting 'baked in' to the build and all the logic with the different process.envs etc was just getting ignored . I did a fresh clone to a different location that wasn't also used for development and that seemed to do it. I also removed the hardcoding of the environment variables from the Dockerfile as well just in case. That way the .env that I have in the place I'm doing the docker compose up from would pass through correctly....

e.g. if you went into the container and looked at the files in the /app/.next/static directory the 'chunk' that was loading the base javascript had o=http:///localhost:5002/ instead of o=i.env.NEXT_PUBLIC_KARRIO_PUBLIC_URL||i.env.KARRIO_PUBLIC_URL;