From e77f12116b0c5797fa26b9b52ca8299f6d7d4694 Mon Sep 17 00:00:00 2001 From: Kartik Raj Date: Wed, 29 Nov 2023 12:32:34 -0800 Subject: [PATCH] Fix shell integration detection --- .../envCollectionActivation/shellIntegrationService.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/client/terminals/envCollectionActivation/shellIntegrationService.ts b/src/client/terminals/envCollectionActivation/shellIntegrationService.ts index 485af6f3cc99..2f3f001ef3c2 100644 --- a/src/client/terminals/envCollectionActivation/shellIntegrationService.ts +++ b/src/client/terminals/envCollectionActivation/shellIntegrationService.ts @@ -53,13 +53,8 @@ export class ShellIntegrationService implements IShellIntegrationService { const deferred = createDeferred(); const timestamp = new Date().getTime(); const name = `Python ${timestamp}`; - const onDidExecuteTerminalCommand = this.appShell.onDidExecuteTerminalCommand?.bind(this.appShell); - if (!onDidExecuteTerminalCommand) { - // Proposed API is not available, assume shell integration is working at this point. - return true; - } try { - const disposable = onDidExecuteTerminalCommand((e) => { + const disposable = this.appShell.onDidExecuteTerminalCommand!((e) => { if (e.terminal.name === name) { deferred.resolve(); }