From fdcdeb7b5e1c322f784c6c764db4d8129363162c Mon Sep 17 00:00:00 2001 From: Eric Pinzur <2641606+epinzur@users.noreply.github.com> Date: Wed, 20 Sep 2023 21:05:16 +0200 Subject: [PATCH] locked python client to engine@v0.11.0 (#764) --- clients/python/pyproject.toml | 2 +- clients/python/src/kaskada/api/release.py | 6 ++++-- clients/python/src/kaskada/api/session.py | 4 ++-- clients/python/tests/api/test_session.py | 6 ++++-- 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/clients/python/pyproject.toml b/clients/python/pyproject.toml index ec5ed9ad4..43e8cba21 100644 --- a/clients/python/pyproject.toml +++ b/clients/python/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "kaskada" -version = "0.5.2" +version = "0.5.3" description = "A client library for the Kaskada time travel machine learning service" authors = ["Kaskada "] license = "Apache-2.0" diff --git a/clients/python/src/kaskada/api/release.py b/clients/python/src/kaskada/api/release.py index ce31c34e7..f61d3660f 100644 --- a/clients/python/src/kaskada/api/release.py +++ b/clients/python/src/kaskada/api/release.py @@ -47,7 +47,7 @@ def download_release( download_path: Path, manager_bin_name: str, engine_bin_name: str, - engine_version: Optional[str] = None, + engine_version: Optional[str] = "engine@v0.11.0", ) -> LocalRelease: """Downloads the appropriate version of the kaskada-manager and kaskada-engine services. @@ -55,7 +55,7 @@ def download_release( download_path (Path): The local download path manager_bin_name (str): The name of the manager binary to save in download path engine_bin_name (str): The name of the engine binary to save in download path - engine_version (Optional[str]): The engine version to download, e.g., engine@v. Defaults to None for latest release. + engine_version (Optional[str]): The engine version to download, e.g., engine@v. Defaults to engine@v0.11.0 Raises: RuntimeError: unable to get release assets @@ -75,6 +75,8 @@ def download_release( repo = self._github.get_repo(f"{self.ORGANIZATION}/{self.REPO_NAME}") + # we don't expect this code path any longer, + # since the default version is now set to a string if engine_version is None: downloaded_release = repo.get_latest_release() logger.info(f"Using latest release version: {downloaded_release.tag_name}") diff --git a/clients/python/src/kaskada/api/session.py b/clients/python/src/kaskada/api/session.py index e24b7e4d3..8364fce81 100644 --- a/clients/python/src/kaskada/api/session.py +++ b/clients/python/src/kaskada/api/session.py @@ -149,14 +149,14 @@ class LocalBuilder(Builder): manager_configs: Dict[str, Any] engine_configs: Dict[str, Any] - # The engine version to download, e.g., `engine@v1.2.3-beta.1`. Defaults to None to get latest release. + # The engine version to download, e.g., `engine@v1.2.3-beta.1`. Defaults to engine@v0.11.0 _engine_version: Optional[str] def __init__( self, endpoint: str = kaskada.client.KASKADA_DEFAULT_ENDPOINT, is_secure: bool = kaskada.client.KASKADA_IS_SECURE, - engine_version: Optional[str] = None, + engine_version: Optional[str] = "engine@v0.11.0", ) -> None: super().__init__() self.manager_configs = {"-no-color": "1"} diff --git a/clients/python/tests/api/test_session.py b/clients/python/tests/api/test_session.py index a8e64ca02..86a43c2c9 100644 --- a/clients/python/tests/api/test_session.py +++ b/clients/python/tests/api/test_session.py @@ -82,14 +82,16 @@ def test_local_builder_set_engine_version(): version = "engine@v0.0.1-beta.1" builder = kaskada.api.session.LocalBuilder().engine_version(version) assert builder._engine_version == version - + + def test_local_builder_set_engine_version_throws(): invalid_versions = ["0.0.1", "engine@0.0.1", "engine@v23", "manager@v1.1.1"] - + for version in invalid_versions: with pytest.raises(ValueError): builder = kaskada.api.session.LocalBuilder().engine_version(version) + def test_local_builder_set_path_sets_path(): path = "my_path" builder = kaskada.api.session.LocalBuilder().path(path)