Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the startup script #35

Open
deunlee opened this issue Apr 28, 2023 · 0 comments
Open

Improving the startup script #35

deunlee opened this issue Apr 28, 2023 · 0 comments

Comments

@deunlee
Copy link

deunlee commented Apr 28, 2023

Hi, I'm looking at your awesome project, it would be better with a little improvement on the startup script.

1. Change VNC username in docker variable

The VNC username is hardcoded in vnc_startup.sh. The password comes from an environment variable, but username does not. I would like to be able to change the username by variable.

echo "kasm_user:${VNC_PW_HASH}:ow" > $PASSWD_PATH
echo "kasm_viewer:${VNC_VIEW_PW_HASH}:" >> $PASSWD_PATH

2. Generate HTTPS certificate once

When the container is running again, vnc_startup.sh executes openssl to regenerate a certificate. It forces the user to refresh the browser, and the user sees self-signed certificate warning again. Therefore, it would be better to use the existing certificate if there is one and create it only if it does not exist. If so, the user will also be able to mount the certificate created by Let's Encrypt into the container.

3. Problem of exposing password

Credentials are passed as parameters when starting some services. (--auth-token "kasm_user:$VNC_PW") If you type ps -aux in the shell you will see the password. So it would be better to save these credentials as a file and set permissions.


Thanks for reading, and if you're busy I can make a PR for a few things so let me know if you think it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant