Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGTERM handling is broken when miner is active #1382

Closed
aspect opened this issue Jan 8, 2021 · 2 comments · Fixed by #1463
Closed

SIGTERM handling is broken when miner is active #1382

aspect opened this issue Jan 8, 2021 · 2 comments · Fixed by #1463
Labels
bug Something isn't working

Comments

@aspect
Copy link
Contributor

aspect commented Jan 8, 2021

It appears that SIGTERM handler is broken in kaspad when kaspaminer is running.

If miner is working, Ctrl+C has no effect on kaspad and after a while results in

2021-01-08 17:01:30.360 [CRT] KASD: Graceful shutdown timed out 2m0s. Terminating...
2021-01-08 17:01:30.360 [INF] KASD: Kaspad shutdown complete
2021-01-08 17:01:30.361 [INF] KASD: Gracefully shutting down the database...
2021-01-08 17:01:30.380 [INF] KASD: Shutdown complete

If after signaling SIGTERM you exit kaspaminer, kaspad exits immediately.

This occurs on Windows platform, but I don't think this matters.
@aspect aspect added the bug Something isn't working label Jan 8, 2021
@aspect
Copy link
Contributor Author

aspect commented Jan 11, 2021

It appears that this problem is related to gRPC and exists as long as any gRPC connections are open. I noticed that the same behavior is exhibited when the wallet is connected.

@stasatdaglabs
Copy link
Collaborator

stasatdaglabs commented Jan 28, 2021 •
edited
Loading

Should be resolved by #1463

@stasatdaglabs stasatdaglabs linked a pull request Jan 28, 2021 that will close this issue
In kaspaminer, don't crash on submitBlock timeout #1462
Merged
@stasatdaglabs stasatdaglabs removed a link to a pull request Jan 28, 2021
In kaspaminer, don't crash on submitBlock timeout #1462
Merged
@stasatdaglabs stasatdaglabs linked a pull request Jan 28, 2021 that will close this issue
Force stop gRPC servers after a short timeout #1463
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force stop gRPC servers after a short timeout kaspanet/kaspad
2 participants
@aspect @stasatdaglabs