Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove overload for session launch #124

Closed
eirrgang opened this issue Jun 26, 2018 · 0 comments
Closed

remove overload for session launch #124

eirrgang opened this issue Jun 26, 2018 · 0 comments
Labels
task Task in support of a larger issue

Comments

@eirrgang
Copy link
Collaborator

The launch() member functions are used by a Context implementation when launching a Session. The future plans for this protocol are described in #44 and also relate to #41, #43, #75, #78, #88, #93.

gmx.core.MDSystem.launch() and gmxapi::System::launch() are overloaded to allow automatic generation of a Context object. gmxapi 0.1 / workspec 0.2 will specify that work specifications are managed by a Context chain of responsibility and that all API operations occur within some sort of Context, though a default Context will be created when the API is initialized. This means that a launch() without arguments, if kept, would have its meaning changed from "create a Context" to "use a Context singleton that already exists". For simplicity, I think it is reasonable that launch() should require either a Context or a Session argument. Whether we require one or the other depends on how the session launching protocol is refined, but either way we know we can simplify life sooner than later by removing the overload with the ambiguous signature.

@eirrgang eirrgang added the task Task in support of a larger issue label Jun 26, 2018
@eirrgang eirrgang closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task in support of a larger issue
Projects
None yet
Development

No branches or pull requests

1 participant