Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatCookieDomain return a wrong value when the domain has a region suffix like www.sina.com.cn #1004

Closed
somethinghero opened this issue May 17, 2018 · 2 comments
Closed

formatCookieDomain return a wrong value when the domain has a region suffix like www.sina.com.cn #1004

somethinghero opened this issue May 17, 2018 · 2 comments
Labels
🤘 status:resolved

Comments

@somethinghero
Copy link

somethinghero commented May 17, 2018 •
edited
Loading

in file cookie.go
the function formatCookieDomain return a wrong value when the domain has a region suffix like www.sina.com.cn
expect return is .sina.com.cn but return .com.cn
@somethinghero
Copy link
Author

somethinghero commented May 17, 2018 •
edited
Loading

I can not find out a good way to solve this problem that consider all kind of domain yet
for example the input maybe:
www.sina.com.cn
www.sina.com
sina.com
sina.com.cn
xxx.sina.com
xxx.sina.com.cn
emmm...

Now I just config DisableSubdomainPersistence to true to ignore the problem

@kataras
Copy link
Owner

kataras commented May 17, 2018

/cc @chengyumeng

relative to: #964

@chengyumeng chengyumeng mentioned this issue May 18, 2018
Merged
@kataras kataras closed this as completed May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤘 status:resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@somethinghero @kataras