Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing coverage information in top-level addons in 0.3.3. #53

Closed
nfc036 opened this issue Oct 10, 2016 · 3 comments
Closed

Missing coverage information in top-level addons in 0.3.3. #53

nfc036 opened this issue Oct 10, 2016 · 3 comments

Comments

@nfc036
Copy link
Contributor

nfc036 commented Oct 10, 2016

Starting from Version 0.3.3 the parameter name in _filterOutAddonFiles is a function and not the actual name. This issue seems fixed when changing line 255 (function _parentName) from

return this.parent.name;

to

return this.parent.pkg.name;
@nfc036
Copy link
Contributor Author

nfc036 commented Oct 10, 2016

... or

return this.parent.name();

as in #52

@rwjblue
Copy link
Collaborator

rwjblue commented Oct 10, 2016

So the underlying issue is tha this.parent is EITHER the project instance (which has a name function) OR an addon instance (which has name as a string property).

The current logic seems like it will work properly for nested addons (because parent.name will be a string), but not for top level addons.

@rwjblue rwjblue changed the title Coverage broken since 0.3.3 Missing coverage information in top-level addons in 0.3.3. Oct 10, 2016
@rwjblue
Copy link
Collaborator

rwjblue commented Oct 10, 2016

Closed by #52

@rwjblue rwjblue closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants