Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files from addons bleed into coverage results #7

Closed
kellyselden opened this issue May 14, 2016 · 5 comments · Fixed by #11
Closed

files from addons bleed into coverage results #7

kellyselden opened this issue May 14, 2016 · 5 comments · Fixed by #11

Comments

@kellyselden
Copy link
Collaborator

Not all the files in the picture are mine, some come from addons:
capture2

@kategengler
Copy link
Collaborator

kategengler commented May 15, 2016

Are the files that are from addons all from addon's app tree? Those are ones I've observed are mingled. How could I filter them out?

Nevermind, I see you have a WIP PR <3

@benoror
Copy link
Contributor

benoror commented May 15, 2016

Can confirm addons files were instrumented too, which were responsible for the discrepancies. PR with @kellyselden changes concerning to Addons files exclusion only: #10

@kellyselden kellyselden changed the title files from addons bleeds into coverage results files from addons bleed into coverage results May 16, 2016
@kategengler
Copy link
Collaborator

I still don't think all addon files bleed into coverage, just those that have been merged with the 'app' tree

@rwjblue
Copy link
Collaborator

rwjblue commented May 17, 2016

Agreed, it should be the addon's app tree files that are bleeding in at the moment.

@sandersky
Copy link
Contributor

Addressed this in #11 which I believe covers more edge cases than #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants