Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated istanbul-api package. #263

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented May 27, 2020

istanbul-api was deprecated in favor of using the individual instanbul-* libraries migrated to here.


Because we don't currently support running code coverage against a dummy app's code, and this addon doesn't have any code in addon/addon-test-support/app I can't actually verify if this is working very easily.

The things that I would like verified are:

  • COVERAGE=true ember test emits a valid coverage file, and the reports look correct
  • the coverage merge functionality still works properly (and can emit a valid final report)

@rwjblue
Copy link
Collaborator Author

rwjblue commented May 27, 2020

@kategengler / @rwwagner90 - Would one of y'all mind testing this against your applications to confirm things are working appropriately?

@RobbieTheWagner
Copy link
Collaborator

@rwjblue happy to help test, but what exactly am I looking for? Just that coverage matches previous versions? I'm trying to identify where the gap in our tests here is and what would be different checking manually in an app. Just want to make sure I am looking for the right things!

@kategengler
Copy link
Collaborator

@rwwagner90 See #264

We discovered the tests weren't running just after this PR.

@RobbieTheWagner
Copy link
Collaborator

@rwjblue I just tried this out and got this._getIncludesForAddonDirectory is not a function or its return value is not iterable

@kategengler
Copy link
Collaborator

@rwwagner90 See #265

@RobbieTheWagner
Copy link
Collaborator

@rwjblue @kategengler let me know when I should test this stuff out then. Happy to help when it's ready!

@Turbo87 Turbo87 force-pushed the remove-deprecated-istanbul-api branch 3 times, most recently from a86b955 to d929e7f Compare August 29, 2020 20:14
@Turbo87
Copy link
Collaborator

Turbo87 commented Aug 29, 2020

I've rebased the commit and resolved the conflicts. CI is green now, so I'm assuming this is good to go?

@RobbieTheWagner
Copy link
Collaborator

@Turbo87 looks like there are some more conflicts. Once resolved, I would assume we could go ahead and merge.

istanbul-api was deprecated in favor of using the individual
`instanbul-*` libraries migrated to here.
@rwjblue
Copy link
Collaborator Author

rwjblue commented Aug 31, 2020

Rebased again.

@rwjblue rwjblue force-pushed the remove-deprecated-istanbul-api branch from d929e7f to a4998ce Compare August 31, 2020 21:21
@rwjblue rwjblue merged commit 0db0982 into master Aug 31, 2020
@rwjblue rwjblue deleted the remove-deprecated-istanbul-api branch August 31, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants