-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-architect plugin loading and asset detection logic (add Embroider support) #327
Re-architect plugin loading and asset detection logic (add Embroider support) #327
Conversation
cc: @rwjblue |
35e3210
to
6ad2450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!!! I left some comments inline, and I also think the README needs some updates; but overall I love it!
6ad2450
to
1c50bfa
Compare
- Adding support for Embroider - Restructure loading of babel plugin - Restructure asset logic
1c50bfa
to
621a7e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small inline comments, but overall this is looking really great!
I think other than the inline comments to address, we need to tweak the README on how to consume (I think your PR description code snippets are good enough there though).
if (opts.embroider === true) { | ||
let { | ||
stableWorkspaceDir, | ||
} = require('@embroider/compat/src/default-pipeline'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get this re-exported from the top level of @embroider/compat
. Maybe we can follow up with that?
Co-authored-by: Robert Jackson <me@rwjblue.com>
cc: @rwjblue Can you take another look at this |
Co-authored-by: Katie Gengler <katie@kmg.io>
For apps (ember-cli-build.js):
For embroider apps (ember-cli-build.js):
For in-repo addons (index.js):
For in-repo engines (index.js):
tests/index.html:
tests/test-helpers.js: