From 5702061a8444eb525e9236e6fb7dbeeed5ee795a Mon Sep 17 00:00:00 2001
From: John Cater <jcater@google.com>
Date: Tue, 26 Mar 2019 11:29:25 -0400
Subject: [PATCH] Mark more things as split factories

---
 .../skylark/StarlarkAttributeTransitionProvider.java         | 5 +++++
 .../devtools/build/lib/analysis/CircularDependencyTest.java  | 5 +++++
 .../google/devtools/build/lib/packages/AttributeTest.java    | 5 +++++
 3 files changed, 15 insertions(+)

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkAttributeTransitionProvider.java b/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkAttributeTransitionProvider.java
index d9cd1bde96d626..b65c57786581e2 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkAttributeTransitionProvider.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/skylark/StarlarkAttributeTransitionProvider.java
@@ -73,6 +73,11 @@ public SplitTransition create(RuleTransitionData data) {
         starlarkDefinedConfigTransition, (ConfiguredAttributeMapper) attributeMap);
   }
 
+  @Override
+  public boolean isSplit() {
+    return true;
+  }
+
   @Override
   public void repr(SkylarkPrinter printer) {
     printer.append("<transition object>");
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java b/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java
index a35cb2d9f33c89..41d6ce0ef90f46 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/CircularDependencyTest.java
@@ -284,6 +284,11 @@ public SplitTransition create(RuleTransitionData data) {
                             return ImmutableList.of(newOptions);
                           };
                         }
+
+                        @Override
+                        public boolean isSplit() {
+                          return true;
+                        }
                       }));
 
   @Override
diff --git a/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java b/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
index b2c5164043a708..1440208210f495 100644
--- a/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
+++ b/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
@@ -311,6 +311,11 @@ private static class TestSplitTransitionProvider
     public SplitTransition create(RuleTransitionData data) {
       return new TestSplitTransition();
     }
+
+    @Override
+    public boolean isSplit() {
+      return true;
+    }
   }
 
   @Test