Skip to content

Commit

Permalink
Remove the command line options --experimental_execution_graph_log_ca…
Browse files Browse the repository at this point in the history
…ched and --experimental_execution_graph_log_missed.

RELNOTES[INC]: The --experimental_execution_graph_log_cached and --experimental_execution_graph_log_missed command line options are not available anymore.

PiperOrigin-RevId: 568833661
Change-Id: Id0af3e942f5d1da27e812edb73b1c5c899bc5dee
  • Loading branch information
lberki authored and copybara-github committed Sep 27, 2023
1 parent 20528af commit 6b204c0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -154,22 +154,6 @@ public static class ExecutionGraphOptions extends OptionsBase {
help = "Subscribe to ActionMiddlemanEvent in ExecutionGraphModule.")
public boolean logMiddlemanActions;

@Option(
name = "experimental_execution_graph_log_cached",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.UNKNOWN},
defaultValue = "true",
help = "Subscribe to CachedActionEvent in ExecutionGraphModule.")
public boolean logCachedActions;

@Option(
name = "experimental_execution_graph_log_missed",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.UNKNOWN},
defaultValue = "true",
help = "Subscribe to ActionCompletionEvent in ExecutionGraphModule.")
public boolean logMissedActions;

@Option(
name = "experimental_execution_graph_enable_edges_from_filewrite_actions",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
Expand Down Expand Up @@ -321,10 +305,8 @@ public void discoverInputs(DiscoveredInputsEvent event) {
@AllowConcurrentEvents
public void actionComplete(ActionCompletionEvent event) {
// TODO(vanja): handle finish time in ActionCompletionEvent
if (options.logMissedActions) {
actionEvent(
event.getAction(), event.getRelativeActionStartTimeNanos(), event.getFinishTimeNanos());
}
actionEvent(
event.getAction(), event.getRelativeActionStartTimeNanos(), event.getFinishTimeNanos());
}

/**
Expand All @@ -335,9 +317,7 @@ public void actionComplete(ActionCompletionEvent event) {
@Subscribe
@AllowConcurrentEvents
public void actionCached(CachedActionEvent event) {
if (options.logCachedActions) {
actionEvent(event.getAction(), event.getNanoTimeStart(), event.getNanoTimeFinish());
}
actionEvent(event.getAction(), event.getNanoTimeStart(), event.getNanoTimeFinish());
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ public void spawnAndAction_withSameOutputs() throws Exception {
var buffer = new ByteArrayOutputStream();
startLogging(eventBus, UUID.randomUUID(), buffer, DependencyInfo.ALL);
var options = new ExecutionGraphModule.ExecutionGraphOptions();
options.logMissedActions = true;
module.setOptions(options);

module.spawnExecuted(
Expand Down Expand Up @@ -438,7 +437,6 @@ public void spawnAndAction_withDifferentOutputs() throws Exception {
var buffer = new ByteArrayOutputStream();
startLogging(eventBus, UUID.randomUUID(), buffer, DependencyInfo.ALL);
var options = new ExecutionGraphModule.ExecutionGraphOptions();
options.logMissedActions = true;
module.setOptions(options);
var nanosToMillis = BlazeClock.createNanosToMillisSinceEpochConverter();
module.setNanosToMillis(nanosToMillis);
Expand Down

0 comments on commit 6b204c0

Please sign in to comment.