Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty data #34

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

pcapriotti
Copy link
Contributor

This fixes an issue with the client when receiving a streaming response from the server. It can happen that too many empty data frames are sent, causing the client to terminate the connection (as a DoS protection).

This fixes an issue with the client when receiving a streaming response
from the server. It can happen that too many empty data frames are sent,
causing the client to terminate the connection (as a DoS protection).
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I confirmed that test fails sometime without the patch for Sender.hs.

@kazu-yamamoto kazu-yamamoto merged commit 8de4585 into kazu-yamamoto:master Dec 14, 2021
@kazu-yamamoto
Copy link
Owner

Merged. Thank you for your contribution!

@kazu-yamamoto
Copy link
Owner

I have released a new version.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 12, 2022
3.0.3
* Return correct status messages in HTTP2 client
  (#31)[kazu-yamamoto/http2#31]
* Follow changes in Aeson 2
  (#32)[kazu-yamamoto/http2#32]
* Make sure connection preface is always sent first
  (#33)[kazu-yamamoto/http2#33]
* Avoid empty data (#34)[kazu-yamamoto/http2#34]

3.0.2
* Skip inserting entries that do not fit in the encoding table
  (#28)[kazu-yamamoto/http2#28]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants