Add linked message formatting #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #467 +/- ##
==========================================
+ Coverage 96.59% 96.64% +0.04%
==========================================
Files 9 9
Lines 647 655 +8
==========================================
+ Hits 625 633 +8
Misses 22 22
Continue to review full report at Codecov.
|
exoego
commented
Nov 17, 2018
|
|
||
| describe('linked translation', () => { |
There was a problem hiding this comment.
Note: Some describe('linked translation', () => { lines are consolidated to single one.
I thinkt it is better to describe one concept that has several test cases.
Before
linked translation
✔️ should foo
linked translation
✔️ should bar
linked translation
✔️ should buz
After
linked translation
✔️ should foo
✔️ should bar
✔️ should buz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #106.
This PR allows linked keys accept formatting modifier in the form of
@.MODIFIER:key.Supported modifiers are below.
upper: Uppercase all the letters.lower:: Uppercase all the letters.The suggested
camelmodifier is not implemented, since usuallythis Is Camel Caseare expected for camel-case.Instead of camel case, I think title-case such is useful, such as
The Catcher in the Rye.Anyway, implementing camel-case and/or title-case is not trivial, so we should consifer using npm module such as to-title-case or similar.