Add support for hot reloading #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
requested changes
Oct 20, 2016
There was a problem hiding this comment.
Thank you for you PR.
I checked your codes.
Great!! 👍
I believe that this features useful in development as with Vuex hot reloading.
All unit tests of this changing is passed. ✅
In sauce labs e2e, failed error, but no worries due to sauce labs setting issues. 😛
However, Seemingly I could not find the hot reloading test cases.
I hope that you add the these test cases. 😉
| ```javascript | ||
| // Support hot updates | ||
| if (module.hot) { | ||
| module.hot.accept(['./en', './cn'], () => { |
There was a problem hiding this comment.
Please adjust the indent 2 spaces level.
|
Added also a test for hot reloading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your project! It's really helped me. ❤️
In development it's annoying to lose the application state after a reload for an updated translation. This PR fixes that by moving the
localesinto the language VM.I also included an example for the documentation for enabling hot reloading of translation.