Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS.supports prevents Codeflask from working in IE11 #79

Closed
marcysutton opened this issue Jul 16, 2018 · 2 comments
Closed

CSS.supports prevents Codeflask from working in IE11 #79

marcysutton opened this issue Jul 16, 2018 · 2 comments

Comments

@marcysutton
Copy link

The CSS.supports call in editor.js throws an unrecoverable error in IE11. Lots of people still use IE, and it's a pretty easy change to get it working. I wrapped it in a try...catch block but there might be a more graceful way to do it.

let COLOR;
try {
  COLOR = (CSS.supports('caret-color', '#000')) ? BACKGROUND_COLOR : '#fff';
} catch (e) {
  COLOR = '#fff';
}
@marcysutton
Copy link
Author

I should mention the styles are also pretty jacked up on iOS Safari.

@kazzkiq kazzkiq closed this as completed in a30d9df Nov 9, 2018
@kazzkiq
Copy link
Owner

kazzkiq commented Nov 9, 2018

I've added an utils function that handles it properly, even for browsers that still doesn't have CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants