add gha test.yml file #140
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #140 +/- ##
===========================================
- Coverage 91.13% 90.49% -0.65%
===========================================
Files 14 14
Lines 1422 1998 +576
===========================================
+ Hits 1296 1808 +512
- Misses 93 157 +64
Partials 33 33 ☔ View full report in Codecov by Sentry. |
| - go: '1.12' | ||
| mongo: 'mongodb-linux-x86_64-3.6.12' | ||
| minio: '2019-05-23T00-29-34Z' | ||
| wired_tiger: 'false' | ||
| - go: '1.12' | ||
| mongo: 'mongodb-linux-x86_64-3.6.20' | ||
| minio: '2019-05-23T00-29-34Z' | ||
| wired_tiger: 'false' | ||
| - go: '1.12' | ||
| mongo: 'mongodb-linux-x86_64-3.6.20' | ||
| minio: '2019-05-23T00-29-34Z' | ||
| wired_tiger: 'true' |
There was a problem hiding this comment.
When you update with mongo 7 you can probably get rid of the 3.6.20 wired_tiger: false matrix entry
There was a problem hiding this comment.
Will do. Also why we test 2 different v3 here?
There was a problem hiding this comment.
At the time, v12 was in production (I think? Might be v13, but pretty close anyway) and v20 was the latest 3.6 release
There was a problem hiding this comment.
Looks like Codecov or the coverage calculator changed how they count lines in missed branches
There was a problem hiding this comment.
Check out the codecov report, you'll see what I mean. More lines are counted as missed but the actual code is the same
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| export TCFG=`pwd`/test.cfg | ||
| BLOBSTORE_TEST_CFG=$TCFG go test -race -coverprofile=coverage.txt -covermode=atomic ./... | ||
|
|
||
| - name: Upload coverage to Codecov |
There was a problem hiding this comment.
@Xiangs18 This is where you activated codecov
There was a problem hiding this comment.
yeah, my question is more like:
codecov/project and codecov/patch checks just come out of box when I activated codecov?
There was a problem hiding this comment.
They do, once you send the coverage file to codecov it does the rest (at least in the kbase org - there might be other setup needed for other orgs)
No description provided.