DEVOPS-1990 Update to go 1.16

[bio-boris]

• Attempt to fix crash from http request

{"log":"panic: runtime error: slice bounds out of range\r\n","stream":"stdout","time":"2024-07-26T22:32:50.680661674Z"}

from

This is where it's happening https://github.com/kbase/blobstore/blob/1cc0178ee0a3814aef917b5d4882d52565911494/filestore/s3.go#L151

[s3.go](https://github.com/kbase/blobstore/blob/1cc0178ee0a3814aef917b5d4882d52565911494/filestore/s3.go)
        return nil, errors.New("s3 store request: " + errstr)

Attempted solution is to upgrade the httplib

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (1cc0178) to head (1fd4d89).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #151   +/-   ##
========================================
  Coverage    90.83%   90.83%           
========================================
  Files           14       14           
  Lines         2073     2073           
========================================
  Hits          1883     1883           
  Misses         157      157           
  Partials        33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MrCreosote]

Other than the loose pinning not much to review here. I assume you're not considering deploying this on Friday and we'd let it sit on CI for a while?

[MrCreosote]

Suggested change

	FROM golang:1.16-alpine as build
	FROM golang:1.16.15-alpine3.15 as build

Is there a reason you're using a looser pinning?

[bio-boris]

I just picked one at random. I doubt they will change after 2 years but its possible. I don't really know how they decide to tag images.
Should we do the following instead?

FROM golang@sha256:9743f230f26d1e300545f0330fd4a514f554c535d967563ee77bf634906502b6 as build
# This golang:1.16-alpine3.15 was tagged Mar 3, 2022 at 9:02 pm

[MrCreosote]

I doubt it too but explicit is better than implicit. I think the version tags are good enough and more readable than a hash

[MrCreosote]

Given we've seen this problem twice in 5 years we're going to have a hard time confirming it's fixed

[MrCreosote]

forgot to mention we'll need release notes and a version bump at some point