Exhaust response body on file store

[MrCreosote]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (f7af00b) to head (f28b856).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #154   +/-   ##
========================================
  Coverage    90.83%   90.83%           
========================================
  Files           14       14           
  Lines         2073     2074    +1     
========================================
+ Hits          1883     1884    +1     
  Misses         157      157           
  Partials        33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bio-boris]

LGTM

This simply defers the closing of the response body until the surrounding function returns. If there is unread data left in the body, it will not be read or discarded, which may prevent connection reuse in HTTP/1.1.

[bio-boris]

The order in which you defer the functions in Go is critical because defer statements are executed in last-in, first-out order when the function returns.

Given the code:

go

defer resp.Body.Close()
defer io.Copy(io.Discard, resp.Body)

These statements will be executed in reverse order when the function returns, meaning io.Copy(io.Discard, resp.Body) will execute before resp.Body.Close().

Very cool!