Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo7 upgrade #114

Merged
merged 24 commits into from
Jun 4, 2024
Merged

Mongo7 upgrade #114

merged 24 commits into from
Jun 4, 2024

Conversation

Xiangs18
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (281d74b) to head (e2ef52e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #114      +/-   ##
===========================================
+ Coverage    83.65%   83.70%   +0.04%     
===========================================
  Files            5        5              
  Lines          410      405       -5     
===========================================
- Hits           343      339       -4     
+ Misses          67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xiangs18 Xiangs18 changed the title [WIP] Mongo7 upgrade Mongo7 upgrade May 28, 2024
@Xiangs18 Xiangs18 requested a review from MrCreosote May 28, 2024 20:01
lib/AbstractHandle/Utils/MongoUtil.py Outdated Show resolved Hide resolved
lib/AbstractHandle/Utils/MongoUtil.py Outdated Show resolved Hide resolved
lib/AbstractHandle/Utils/MongoUtil.py Outdated Show resolved Hide resolved
lib/AbstractHandle/Utils/MongoUtil.py Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

@Xiangs18 Xiangs18 requested a review from MrCreosote May 30, 2024 16:24
lib/AbstractHandle/Utils/MongoUtil.py Outdated Show resolved Hide resolved
test/config_test.py Outdated Show resolved Hide resolved
test/config_test.py Outdated Show resolved Hide resolved
test/config_test.py Outdated Show resolved Hide resolved
test/mongo_util.py Outdated Show resolved Hide resolved
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @Tianhao-Gu should do the final review

@MrCreosote MrCreosote dismissed github-actions[bot]’s stale review May 31, 2024 18:36

Lintly doesn't seem to dismiss old reviews when it passes

@Xiangs18 Xiangs18 requested a review from Tianhao-Gu May 31, 2024 18:36
Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xiangs18 Xiangs18 merged commit 2213d27 into develop Jun 4, 2024
11 checks passed
@Xiangs18 Xiangs18 deleted the dev-mongodb_upgrade branch June 4, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants