New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVOPS-1955 Lazy Load Mongo Client #119

Merged

Tianhao-Gu merged 12 commits into develop from change_log_level_to_debug

Jun 24, 2024

+135 −88

Contributor

bio-boris commented Jun 21, 2024 •

edited

Loading

6/21/2024 3:50:34 PM1719003034.428176 INFO: start fetching handles
6/21/2024 3:50:34 PM1719003034.428512 INFO: start querying MongoDB
6/21/2024 3:50:34 PM/usr/local/lib/python3.9/site-packages/pymongo/mongo_client.py:2347: UserWarning: MongoClient opened before fork. May not be entirely fork-safe, proceed with caution. See PyMongo's documentation for details: https://pymongo.readthedocs.io/en/stable/faq.html#is-pymongo-fork-safe
6/21/2024 3:50:34 PM  return self._read() if self._is_read else self._write()

After this PR, this error no longer occurs

Updates 4dba659 to lazy load
Fixes formatting errors from lintly
Fixes tests


          Update AbstractHandleImpl.py

53100b3

codecov bot commented Jun 21, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 82.45614% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.13%. Comparing base (852313d) to head (ec26804).

Files	Patch %	Lines
lib/AbstractHandle/Utils/MongoUtil.py	82.45%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #119      +/-   ##
===========================================
+ Coverage    83.70%   84.13%   +0.43%     
===========================================
  Files            5        5              
  Lines          405      416      +11     
===========================================
+ Hits           339      350      +11     
  Misses          66       66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


          Update mongo init

4dba659

github-actions bot requested changes

View reviewed changes

github-actions bot left a comment

Lintly has detected code quality issues in this pull request.


          Update mongo init

3da3e18

github-actions bot requested changes

View reviewed changes

github-actions bot left a comment

Lintly has detected code quality issues in this pull request.

bio-boris changed the title ~~Change Log Level to Debug~~ DEVOPS-1954 Change Log Level to Debug


          Fixed formatting

33407a1

github-actions bot requested changes

View reviewed changes

github-actions bot left a comment

Lintly has detected code quality issues in this pull request.


          Fixed formatting

6529d2c

github-actions bot requested changes

View reviewed changes

github-actions bot left a comment

Lintly has detected code quality issues in this pull request.


          Ran black

4cd6c8b

github-actions bot requested changes

View reviewed changes

github-actions bot left a comment

Lintly has detected code quality issues in this pull request.


          Ran black

9af00c9

bio-boris changed the title ~~DEVOPS-1954 Change Log Level to Debug~~ DEVOPS-1954 Lazy Load Mongo Client

github-actions bot previously requested changes

View reviewed changes

github-actions bot left a comment

Lintly has detected code quality issues in this pull request.

bio-boris requested review from ialarmedalien, Tianhao-Gu, Xiangs18 and kkellerlbl

June 21, 2024 21:39

Boris added 4 commits

June 21, 2024 16:39


          Ran black

0cf4701


          Ran black

1bc0e1a


          Revert log level

78cc9f9


          Attempt to fix set tests

e8e8a35

bio-boris commented

View reviewed changes

test/MongoUtil_test.py

@@ @@ -66,10 +66,15 @@ def test_get_collection(self): @@
                   def test_init_ok(self):
                       self.start_test()
                       class_attri = [
-                          'mongo_host', 'mongo_port', 'mongo_database', 'handle_collection',
-                          'hid_counter_collection',
+                          'mongo_host', 'mongo_port', 'mongo_database', '_handle_collection',

Contributor Author

bio-boris Jun 21, 2024

Had to rewrite tests here

bio-boris commented

View reviewed changes

lib/AbstractHandle/Utils/MongoUtil.py

+                      )
+                  @property
+                  def handle_collection(self):

Contributor Author

bio-boris Jun 21, 2024

added property here

bio-boris commented

View reviewed changes

lib/AbstractHandle/Utils/MongoUtil.py

+                      return self._handle_collection
+                  @property
+                  def hid_counter_collection(self):

Contributor Author

bio-boris Jun 21, 2024

added property here

bio-boris changed the title ~~DEVOPS-1954 Lazy Load Mongo Client~~ DEVOPS-1955 Lazy Load Mongo Client

Tianhao-Gu approved these changes

View reviewed changes

Collaborator

Tianhao-Gu left a comment

code changes looks good. Do we need to bump versions/ update release notes, etc for prod release?


          Update RELEASE_NOTES.md

ec26804

Contributor Author

bio-boris commented Jun 24, 2024

Thanks @Tianhao-Gu . I updated the release notes to include this change. I don't think we need to bump the version as we only every deployed 1.0.5 anywhere.

Collaborator

Tianhao-Gu commented Jun 24, 2024

Thanks @Tianhao-Gu . I updated the release notes to include this change. I don't think we need to bump the version as we only every deployed 1.0.5 anywhere.

💯

Tianhao-Gu dismissed github-actions[bot]’s stale review

June 24, 2024 16:12

bypass linter

Tianhao-Gu merged commit 17a8210 into develop

12 of 13 checks passed

Tianhao-Gu deleted the change_log_level_to_debug branch

June 24, 2024 16:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Tianhao-Gu Tianhao-Gu approved these changes

github-actions[bot] github-actions[bot] left review comments

ialarmedalien Awaiting requested review from ialarmedalien

Xiangs18 Awaiting requested review from Xiangs18

kkellerlbl Awaiting requested review from kkellerlbl

Labels

None yet