Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently ignore checkbox value fields #89

Open
MrCreosote opened this issue Feb 23, 2022 · 0 comments
Open

Silently ignore checkbox value fields #89

MrCreosote opened this issue Feb 23, 2022 · 0 comments

Comments

@MrCreosote
Copy link
Member

MrCreosote commented Feb 23, 2022

The checkbox fields checked_value and unchecked_value are actually completely ignored by the narrative when sending values to an app, and in practice the narrative always sends a 1 for a checked box and a 0 for an unchecked box, regardless of the values of the spec fields.

Furthermore, the NMS silently changes any non-integer field value to 0.

Since the fields are useless and buggy, the current narrative implementation makes intuitive sense anyway, and said implementation been working for 5+ years, just remove the fields from the spec and silently ignore them to avoid breaking current apps with those fields specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant