-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.3.12 release (develop -> master) #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should no longer need submodules, will remove later * Jars are now expected to be a sister folder (which will be removed with the Gradle conversion * module_builder seems to only be used in `test/data/test_repo_1/service/init.sh` which is not called from anywhere, and deleting it doesn't cause the tests to fail
Just makes the image build - haven't tested that the server works, will do that later
Add GHA tests, update GHA, simplify tests, remove cruft
Add gradle
jars is no longer needed w/ Gradle module_builder is no longer referenced anywhere in the project
Remove submodules
Remove perl scripts
Only called in one place in tests and the method called is completely commented out and does nothing
Unused
Remove code cruft
Unused, config was commented out
Update dockerfile to use gradle and remove old build cruft
Remove shock client
Move source to standard Gradle layout
Use jitpacked jars
mongo7 upgrade
add retryWrites
MrCreosote
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously not going to go through this line by line as it's all been reviewed already, but skimming the file changes and doing some spot checks looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.