Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.12 release (develop -> master) #102

Merged
merged 42 commits into from
Nov 22, 2024
Merged

0.3.12 release (develop -> master) #102

merged 42 commits into from
Nov 22, 2024

Conversation

Xiangs18
Copy link
Collaborator

No description provided.

MrCreosote and others added 30 commits April 16, 2024 20:46
Should no longer need submodules, will remove later
* Jars are now expected to be a sister folder (which will be removed
with the Gradle conversion
* module_builder seems to only be used in
`test/data/test_repo_1/service/init.sh` which is not called from
anywhere, and deleting it doesn't cause the tests to fail
Just makes the image build - haven't tested that the server works, will
do that later
Add GHA tests, update GHA, simplify tests, remove cruft
jars is no longer needed w/ Gradle
module_builder is no longer referenced anywhere in the project
Only called in one place in tests and the method called is completely
commented out and does nothing
Unused, config was commented out
Update dockerfile to use gradle and remove old build cruft
Move source to standard Gradle layout
@Xiangs18 Xiangs18 requested a review from MrCreosote November 20, 2024 23:53
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously not going to go through this line by line as it's all been reviewed already, but skimming the file changes and doing some spot checks looks good

@Xiangs18 Xiangs18 merged commit e43a999 into master Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants