Remove code cruft #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only called in one place in tests and the method called is completely commented out and does nothing
Unused
MrCreosote
commented
Apr 25, 2024
| @@ -214,7 +213,6 @@ public void testPy() throws Exception { | |||
| String dockerCommands = "RUN DEBIAN_FRONTEND=noninteractive apt-get update;" + | |||
| "apt-get -y upgrade;apt-get install -y libblas3gf liblapack3gf libhdf5-serial-dev\n" + | |||
| "RUN pip install tables"; | |||
| PySrvRepoPreparator.prepare(userId, moduleName, methodSpec, pythonCode, dockerCommands, repoDir); | |||
There was a problem hiding this comment.
This method is completely commented out and does nothing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #94 +/- ##
=============================================
+ Coverage 64.19% 70.67% +6.47%
Complexity 1457 1457
=============================================
Files 101 91 -10
Lines 5600 5087 -513
Branches 575 490 -85
=============================================
Hits 3595 3595
+ Misses 1775 1262 -513
Partials 230 230 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of this code is isolated and unused by the main code base