Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongo7 upgrade #99

Merged
merged 12 commits into from
Oct 28, 2024
Merged

mongo7 upgrade #99

merged 12 commits into from
Oct 28, 2024

Conversation

Xiangs18
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.06%. Comparing base (9d204a4) to head (dd85c57).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...rativemethodstore/db/mongo/MongoDynamicRepoDB.java 97.10% 2 Missing ⚠️
...base/narrativemethodstore/db/mongo/MongoUtils.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #99      +/-   ##
=============================================
- Coverage      71.09%   70.06%   -1.04%     
+ Complexity      1457     1437      -20     
=============================================
  Files             91       91              
  Lines           5048     5034      -14     
  Branches         478      479       +1     
=============================================
- Hits            3589     3527      -62     
- Misses          1239     1296      +57     
+ Partials         220      211       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xiangs18 Xiangs18 changed the title [WIP] mongo7 upgrade mongo7 upgrade Oct 22, 2024
@Xiangs18 Xiangs18 requested a review from MrCreosote October 22, 2024 18:44
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self - didn't review MongoUtils, MongoDBHelper changes yet

@Xiangs18 Xiangs18 requested a review from MrCreosote October 23, 2024 23:56
@MrCreosote
Copy link
Member

I don't understand where the +57 codecov misses are coming from, looking at the actual report at codecov there's definitely not 57 new uncovered lines

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a lot of under the hood behavioral changes now, which look like they should have the same result and aren't subject to race conditions, but the low code coverage for this repo makes me nervous. I think this one is going to need some manual testing covering the altered code paths

@Xiangs18
Copy link
Collaborator Author

I don't understand where the +57 codecov misses are coming from, looking at the actual report at codecov there's definitely not 57 new uncovered lines

Where did you see the +57 Codecov misses? What I saw is this link.

@MrCreosote
Copy link
Member

image

@Xiangs18 Xiangs18 requested a review from MrCreosote October 28, 2024 18:55
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You're def going to want to run some manual tests to check the pull and replace vs. update changes work as expected

@Xiangs18 Xiangs18 merged commit a43205e into develop Oct 28, 2024
9 of 10 checks passed
@Xiangs18 Xiangs18 deleted the dev-mongo7_upgrade branch October 28, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants