Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: less aggressive coloring #110

Closed
Byron opened this issue May 6, 2015 · 2 comments
Closed

suggestion: less aggressive coloring #110

Byron opened this issue May 6, 2015 · 2 comments

Comments

@Byron
Copy link
Contributor

Byron commented May 6, 2015

In v0.8.0, text coloring was introduced which I generally am a great fan of. Having it in usage strings seems like something I definitely want to have.

The first implementation of it applies it to the entire output of the usage string, which doesn't help one to focus on what's actually the problem.
Therefore I would recommend to use color (and/or bold text) only to highlight portions of it, like the required parameters that were missing. This could also be used to highlight suggestions in a friendly color.
Of course, a disclaimer shall be placed here that this is a somewhat cosmetical issue which is to some extend subjective. This issue is nothing more than a suggestion.

As a side-note, thanks for implementing everything with dependencies in a feature-gated fashion to allow an opt-out, which is what I chose as an intermediate solution in my case. Generally, that's a great practice that I will adopt were adequate as well.

@kbknapp
Copy link
Member

kbknapp commented May 6, 2015

I agree. Perhaps the entire string being red is a bit much. I want avoid having rainbow output though where errors are one color, suggestions another, regular out another, etc. Perhaps a good middle ground would be the error and suggestions are red, the usage and "for more information" string are regularly formatted.

@kbknapp kbknapp mentioned this issue May 6, 2015
@Byron
Copy link
Contributor Author

Byron commented May 6, 2015

Sounds good to me ! I am watching the PR and will give it a whirl once I have a minute.
Thanks for taking care.

@kbknapp kbknapp closed this as completed in aab44cc May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants