Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape quotes in completions #704

Closed
tilpner opened this issue Oct 25, 2016 · 2 comments
Closed

Escape quotes in completions #704

tilpner opened this issue Oct 25, 2016 · 2 comments
Labels
A-completion Area: completion generator C-bug Category: Updating dependencies
Milestone

Comments

@tilpner
Copy link

tilpner commented Oct 25, 2016

rustup just exposed completion generation, but fish complains about the generated completions

Unexpected end of string, quotes are not balanced
~/.config/fish/completions/rustup.fish (line 188): complete -c rustup -n '__fish_using_command rustup help' -s V -l version -d 'Prints version information'

                  ^
from sourcing file ~/.config/fish/completions/rustup.fish
    called on standard input

in command substitution
    called on standard input

source: Error while reading file “/home/till/.config/fish/completions/rustup.fish”

The completions don't escape the help items, leading to the ' in "Don't" ending the help string, breaking the rest of the file.

ping @brson

@kbknapp
Copy link
Member

kbknapp commented Oct 25, 2016

Thanks for the heads up! I should have this fixed first thing tomorrow 👍

@kbknapp kbknapp added C-bug Category: Updating dependencies P1: urgent A-completion Area: completion generator labels Oct 25, 2016
@kbknapp kbknapp added this to the 2.16.2 milestone Oct 25, 2016
@kbknapp
Copy link
Member

kbknapp commented Oct 25, 2016

This is fixed in #705

Once it merges I'll put v2.16.2 on crates.io

@homu homu closed this as completed in 780b4a1 Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion Area: completion generator C-bug Category: Updating dependencies
Projects
None yet
Development

No branches or pull requests

2 participants