Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly distinguish between multiple values, and multiple allowances #99

Closed
kbknapp opened this issue May 4, 2015 · 0 comments
Closed
Assignees
Labels
C-enhancement Category: Raise on the bar on expectations
Milestone

Comments

@kbknapp
Copy link
Member

kbknapp commented May 4, 2015

This is a slightly breaking change - not enough to warrant a label.

Currently, using named values -f <file> <mode> requires you to set multiple(true)...but this isn't correct logic. By this token, someone could legally do:

$ myprog -f some.txt fast -f other.txt slow

This may, or may not, be what the developer wanted. Setting multiple(true) shouldn't be a requirement for named values...only for unnamed multiple values. This allows the developer to decide which style of argument he wants, multiple allowances, or multiple values.

@kbknapp kbknapp added the C-enhancement Category: Raise on the bar on expectations label May 4, 2015
@kbknapp kbknapp added this to the 1.0 Release milestone May 4, 2015
@kbknapp kbknapp self-assigned this May 4, 2015
@kbknapp kbknapp closed this as completed in dd2a756 May 5, 2015
kbknapp added a commit that referenced this issue May 5, 2015
Fixes #99 as well as other misc fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Development

No branches or pull requests

1 participant