Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "check_emcc" fails after merged upstream #20

Closed
rowntreerob opened this issue Jul 11, 2019 · 4 comments
Closed

make "check_emcc" fails after merged upstream #20

rowntreerob opened this issue Jul 11, 2019 · 4 comments

Comments

@rowntreerob
Copy link

https://github.com/kbumsik/opus-media-recorder/blob/master/Makefile#L212
throws the following on linux system :

/bin/sh: 1: test: 1.38.34: unexpected operator

causing make target "check_emcc" to fail

RE: https://stackoverflow.com/questions/3411048/unexpected-operator-in-shell-programming

removing one of the "=" in the "==" operator solved the problem.

@rowntreerob
Copy link
Author

--- a/Makefile
+++ b/Makefile
@@ -209,7 +209,8 @@ $(DIST_DIR)/%.bin: $(BUILD_DIR)/%.wasm
cc_version = $(shell $(1) --version | head -n1 | cut -d" " -f5)

define check_version

  •   @if test "$$(printf '%s\n' "$(1)" "$(2)" | sort -V | head -2 | tail -1)" == "$(2)"; then \
    
  •   @if test "$$(printf '%s\n' "$(1)" "$(2)" | sort -V | head -2 | tail -1)" = "$(2)"; then \
              exit 0; \
    

@kbumsik
Copy link
Owner

kbumsik commented Jul 12, 2019

@rowntreerob I accepted your suggestion. Thank you for reporting!
Just out of curiosity, which Linux are you using? I'm using Arch Linux and Windows Ubuntu (WSL) but I haven't noticed the problem.

@rowntreerob
Copy link
Author

I USE bash shell on ubuntu 16.04

@kbumsik
Copy link
Owner

kbumsik commented Jul 12, 2019

@rowntreerob I see, I will make sure if the build tools work on Ubuntu. Thanks very much for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants