-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generation number doesn't seem correctly set on cached builtin resources. #2935
Comments
@p0lyn0mial do you happen to remember if this issue is still up to date and/or valid? |
I think so, we wanted to fix it with kcp-dev/kubernetes#132 |
and the test still (https://github.com/kcp-dev/kcp/blob/main/test/e2e/reconciler/cache/replication_test.go#L683) seems to be removing the "generation" field before comparison. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
When completing the
replication_test.go
e2e cache test with replication scenarios of rbac resources (CR / CRB objects), the generation is not equal when comparing original and cached objects.I added a TODO in the completed test:
kcp/test/e2e/reconciler/cache/replication_test.go
Lines 706 to 716 in cf8a625
Maybe the work done for CRD-backed resources in this PR should also be done for built-in resources that support replication ?
The text was updated successfully, but these errors were encountered: