Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commentjson dependency #1152

Closed
johanneskastl opened this issue Nov 29, 2024 · 3 comments
Closed

Remove commentjson dependency #1152

johanneskastl opened this issue Nov 29, 2024 · 3 comments
Labels
📦 dependencies Update of dependencies ✨ enhancement Improvement or change to an existing feature

Comments

@johanneskastl
Copy link

"commentjson ~= 0.9.0",

While packaging click-extra for openSUSE I found that the commentjson dependency is ugly. It seems to be inactive, which means it still pulls in six for the tests. And it depends on lark-parser, which was renamed to lark apparently a while ago.

Could you check if this is still required? Could it be replaced with something maintained?

Kind Regards,
Johannes

@kdeldycke kdeldycke added 📦 dependencies Update of dependencies ❔ question Further information is requested labels Nov 30, 2024
@kdeldycke
Copy link
Owner

Yeah, I'm also annoyed by commentjson being unmaintained. It's sad as it is a great quality of life improvement, especially for JSON configuration file.

So yeah, if it can make your life as a packager easier, I'll get rid of it. You are doing a great job packaging Click Extra, which is more important as it will increase adoption.

@kdeldycke kdeldycke added the ✨ enhancement Improvement or change to an existing feature label Nov 30, 2024
@kdeldycke kdeldycke changed the title Dependency on commentjson still required? Remove commentjson dependency Nov 30, 2024
@kdeldycke kdeldycke removed the ❔ question Further information is requested label Nov 30, 2024
@kdeldycke
Copy link
Owner

Done: Click Extra 4.11.7 has been released without commented JSON support.

@johanneskastl
Copy link
Author

Thanks a lot, Kevin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 dependencies Update of dependencies ✨ enhancement Improvement or change to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants