Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add latency switch #77

Merged
merged 1 commit into from
Jul 18, 2023
Merged

add latency switch #77

merged 1 commit into from
Jul 18, 2023

Conversation

ii2day
Copy link
Collaborator

@ii2day ii2day commented Jul 12, 2023

#76

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #77 (73b68a0) into main (b026a76) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   40.28%   40.64%   +0.36%     
==========================================
  Files           8        8              
  Lines         494      497       +3     
==========================================
+ Hits          199      202       +3     
  Misses        291      291              
  Partials        4        4              
Flag Coverage Δ
unittests 40.64% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/loadRequest/loadDns/dns.go 92.10% <100.00%> (+0.21%) ⬆️
pkg/loadRequest/loadDns/dns_reporter.go 86.20% <100.00%> (+0.49%) ⬆️
pkg/loadRequest/loadDns/dns_requester.go 97.36% <100.00%> (+0.02%) ⬆️

@ii2day ii2day force-pushed the pr/ii2day/latency branch 2 times, most recently from 2bccfe0 to 87e3cca Compare July 12, 2023 10:55
@weizhoublue
Copy link
Collaborator

enableLatencyMetric 不能加在 schedule 中,这个 struct 是通用的,未来如果其他任务 没有metric 就不适用了

@ii2day
Copy link
Collaborator Author

ii2day commented Jul 13, 2023

enableLatencyMetric 不能加在 schedule 中,这个 struct 是通用的,未来如果其他任务 没有metric 就不适用了

那这种配置放到 annoation 中?

Signed-off-by: ii2day <ji.li@daocloud.io>
@ii2day ii2day force-pushed the pr/ii2day/latency branch from 87e3cca to 73b68a0 Compare July 13, 2023 06:13
@ii2day
Copy link
Collaborator Author

ii2day commented Jul 13, 2023

enableLatencyMetric 不能加在 schedule 中,这个 struct 是通用的,未来如果其他任务 没有metric 就不适用了

done

@weizhoublue weizhoublue merged commit 141cdc9 into main Jul 18, 2023
@ii2day ii2day deleted the pr/ii2day/latency branch September 4, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants