Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the new default values for T and minfup if not specified #132

Open
nanxstats opened this issue Feb 29, 2024 · 0 comments
Open

Explain the new default values for T and minfup if not specified #132

nanxstats opened this issue Feb 29, 2024 · 0 comments
Assignees
@nanxstats

Comments

@nanxstats
Copy link
Collaborator

We should explain the new default values for the important arguments T and minfup if they are not specified in the function call. This follows the tidy design principles.

Since the breaking change was made in gsDesign 3.6.0, two or more users have asked why they can't reproduce previous results when using the exact same code under gsDesign >=3.6.0.

Could use a unit test to ensure this works.
@nanxstats nanxstats self-assigned this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanxstats nanxstats

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nanxstats