You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using sfLDOF(), the summary text can be a bit confusing:
summary(sfLDOF(alpha=0.25, t=0.5, param=0))
#> "Lan-DeMets O'Brien-Fleming approximation spending function with none = 1"
@elong0527 wonders if it makes more sense to display "... with no parameters".
Since the relevant logic in sfLDOF() seems intentional and might be written this way for a reason, I will let you make the decision.
Technical details
The call sequence is summary.spendfn() -> sfLDOF(). Here, since param = 0, sfLDOF() will set param to 1, and set parname to "none". Then summary.spendfn() will print parname = param (none = 1).
When using
sfLDOF()
, the summary text can be a bit confusing:@elong0527 wonders if it makes more sense to display "... with no parameters".
Since the relevant logic in
sfLDOF()
seems intentional and might be written this way for a reason, I will let you make the decision.Technical details
The call sequence is
summary.spendfn()
->sfLDOF()
. Here, sinceparam = 0
,sfLDOF()
will setparam
to 1, and setparname
to"none"
. Thensummary.spendfn()
will printparname = param
(none = 1
).gsDesign/R/gsMethods.R
Lines 811 to 816 in cbf9a94
gsDesign/R/gsSpending.R
Lines 711 to 717 in cbf9a94
The text was updated successfully, but these errors were encountered: