-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RBAC namespace selection for metrics server #674
Adding RBAC namespace selection for metrics server #674
Conversation
Signed-off-by: Nils <kurt.rotzke@gmail.com>
Hi @JorTurFer ! I have made a duplicate of #657 because it is stuck since the 28. of June and I was actually the one who requested the feature, please review my MR, I excluded version changes as you requested in the initial MR. |
To make users 100% aware of the goal, we could call the parameter like |
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
@JorTurFer I have renamed the variables, haven't really found those docs you mentioned, though it is not a command line argument for any of control plane components, I guess. Can we still get this merged into the next release/minor/patch version? Would be really cool, we are shivering in anticipation, waited for some time. Thanks in advance! |
Yeah! just let me look for the link a few days more and definitively this will be included for next version |
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
* Added required namespace variable and values file entry, updated docs Signed-off-by: Nils <kurt.rotzke@gmail.com> * Added required namespace variable and values file entry, updated docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> --------- Signed-off-by: Nils <kurt.rotzke@gmail.com> Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
* Added required namespace variable and values file entry, updated docs Signed-off-by: Nils <kurt.rotzke@gmail.com> * Added required namespace variable and values file entry, updated docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> * Updated helm-docs Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com> --------- Signed-off-by: Nils <kurt.rotzke@gmail.com> Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Provide a description of what has been changed
Checklist
Fixes #645