Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Scaler- brokerlist should be removed from the example in document #519

Closed
Ritikaa96 opened this issue Aug 26, 2021 · 3 comments · Fixed by #520
Closed

Kafka Scaler- brokerlist should be removed from the example in document #519

Ritikaa96 opened this issue Aug 26, 2021 · 3 comments · Fixed by #520
Labels
bug Something isn't working

Comments

@Ritikaa96
Copy link
Contributor

A clear and concise description of what the bug is.

As per : kedacore/keda#882
brokerList for Kafka Scaler has been deprecated.
we can see it's mention on the example for metadata here: https://keda.sh/docs/2.4/scalers/apache-kafka/#trigger-specification

As this has been deprecated since v1.3 earliest, can we remove the mention now as not to confuse the user?

Expected Behavior

brokerList should not be mentioned anymore.

Actual Behavior

we can see the mention here: https://keda.sh/docs/2.4/scalers/apache-kafka/#trigger-specification

Steps to Reproduce the Problem

  1. go to https://keda.sh/docs/2.4/scalers/apache-kafka/#trigger-specification
  2. check out the metadata.

Specifications

  • KEDA Version: any
  • Platform & Version: any
  • Kubernetes Version: 1.20.2
  • Scaler(s): Apache Kafka
@Ritikaa96 Ritikaa96 added the bug Something isn't working label Aug 26, 2021
@Ritikaa96
Copy link
Contributor Author

@tomkerkhove @zroubalik @ahmelsayed let me know what you think.

@zroubalik
Copy link
Member

Good catch, if I am not mistaken it should be removed from all 2.x versions of docs.

@Ritikaa96
Copy link
Contributor Author

@zroubalik Yes, we can see the v2.0.0 release notes, the deprecation is mentioned in breaking changes for kafka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants