fix: Add missing docs for redis-stream merged feature #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JorTurFer
changed the title
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
JorTurFer
changed the title
tomkerkhove
approved these changes
Feb 5, 2024
ArunYogesh
pushed a commit
to ArunYogesh/keda-docs
that referenced
this pull request
Mar 1, 2024
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com>
JorTurFer
added a commit
that referenced
this pull request
Mar 10, 2024
#1305) * chore: add missing space in the Activation parameter explanation (#1299) Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com> * update arangodb.md (#1300) Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com> * fix: Add missing docs for redis-stream merged feature (#1304) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com> * docs(scalers): Add documentation for an additional configuration that is being exposed (#5474 - kedacore) Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com> * Renamed serviceName to kerberosServiceName for clarity Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com> --------- Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com> Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Adarsh Verma <113962919+Adarsh-verma-14@users.noreply.github.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We merged this PR but we didn't notice that the feature was added to all the redis scalers although docs weren't updated for all of them.
I've added the missing changes in redis-stream scaler. I've double-checked and it has the feature enabled and tested in the code so I'd say that only docs updating is missing (although another check'd be nice too xD)
Checklist
Fixes #