Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ignoreNullValues for AWS CloudWatch Scaler #1346

Merged
merged 10 commits into from
Aug 20, 2024
Merged

add ignoreNullValues for AWS CloudWatch Scaler #1346

merged 10 commits into from
Aug 20, 2024

Conversation

robpickerill
Copy link
Contributor

@robpickerill robpickerill commented Mar 28, 2024 •
edited
Loading

Adds documentation for the errorWhenMetricValuesEmpty metadata option for the AWS Cloudwatch Scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #5352

@robpickerill robpickerill requested a review from a team as a code owner March 28, 2024 15:44
@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit aaee085
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66c4e3aa407aef00084a7d4a
😎 Deploy Preview https://deploy-preview-1346--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch 2 times, most recently from 0116ef3 to 9278bd7 Compare March 28, 2024 18:09
@robpickerill
add errorWhenMetricValueEmpty
e42d3fc 
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from 9278bd7 to e42d3fc Compare March 28, 2024 18:10
@robpickerill robpickerill changed the title add errorWhenMetricValueEmpty add errorWhenNullValues for AWS CloudWatch Scaler Apr 4, 2024
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch 2 times, most recently from d690501 to b890a2d Compare April 4, 2024 19:18
@robpickerill
rename errorWhenMetricValuesEmpty -> errorWhenNullValues
0879714 
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from b890a2d to 0879714 Compare April 4, 2024 19:29
@robpickerill robpickerill changed the title add errorWhenNullValues for AWS CloudWatch Scaler add ignoreNullValues for AWS CloudWatch Scaler Apr 11, 2024
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch 3 times, most recently from 04d3c4a to 3298a02 Compare April 11, 2024 20:38
@robpickerill
rename errorWhenMetricValuesEmpty -> ignoreNullValues
3e32ad8 
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from 3298a02 to 3e32ad8 Compare April 11, 2024 20:38
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from 80bb64d to af37362 Compare May 17, 2024 10:50
@robpickerill
move ignoreNullValues to 2.15
163b22c 
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from af37362 to 163b22c Compare May 17, 2024 10:52
JorTurFer
JorTurFer reviewed May 21, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A minor thing, could you remove references to aws-kiam? It was deprecated and this version removes it

@robpickerill
Copy link
Contributor Author

Looking good! A minor thing, could you remove references to aws-kiam? It was deprecated and this version removes it

Missed this, apologies, I'll fix this shortly

@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from 30ddb0d to 6fb1ea5 Compare August 16, 2024 09:17
JorTurFer
JorTurFer reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have already shipped v2.15, could you move this change to v2.16 please?

@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from 18dece9 to dd072c3 Compare August 20, 2024 08:05
@robpickerill
move ignoreNullValues to 2.16
e6a0033 
Signed-off-by: robpickerill <r.pickerill@gmail.com>
@robpickerill robpickerill force-pushed the cloudwatch-error-when-empty-metrics branch from dd072c3 to e6a0033 Compare August 20, 2024 08:12
@JorTurFer JorTurFer enabled auto-merge (squash) August 20, 2024 21:38
@JorTurFer JorTurFer merged commit 311805c into kedacore:main Aug 20, 2024
7 checks passed
@robpickerill robpickerill deleted the cloudwatch-error-when-empty-metrics branch August 21, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Cloudwatch Scaler, do nothing on empty metric data received
2 participants
@robpickerill @JorTurFer