From 603831c21c06ac554e585b382eec98e33b44f3af Mon Sep 17 00:00:00 2001 From: JosephABC Date: Wed, 23 Nov 2022 17:38:17 +0800 Subject: [PATCH 1/2] Add Documentation for excludePersistentLag Signed-off-by: JosephABC --- content/docs/2.9/scalers/apache-kafka.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/docs/2.9/scalers/apache-kafka.md b/content/docs/2.9/scalers/apache-kafka.md index 7df7c34de..f53b5d155 100644 --- a/content/docs/2.9/scalers/apache-kafka.md +++ b/content/docs/2.9/scalers/apache-kafka.md @@ -31,6 +31,7 @@ triggers: offsetResetPolicy: latest allowIdleConsumers: false scaleToZeroOnInvalidOffset: false + excludePersistentLag: false version: 1.0.0 ``` @@ -47,6 +48,7 @@ partitions on a topic, allowing for idle consumers. (Default: `false`, Optional) - `scaleToZeroOnInvalidOffset` - This parameter controls what the scaler does when a partition doesn't have a valid offset. If 'false' (the default), the scaler will keep a single consumer for that partition. Otherwise ('true'), the consumers for that partition will be scaled to zero. See the [discussion](https://github.com/kedacore/keda/issues/2612) about this parameter. +- `excludePersistentLag` - When set to `true`, the scaler will exclude partition lag for partitions which current offset is the same as the current offset of the previous polling cycle. This parameter is useful to prevent scaling due to partitions which current offset message is unable to be consumed. - `version` - Version of your Kafka brokers. See [samara](https://github.com/Shopify/sarama) version (Default: `1.0.0`, Optional) > **Note:** From 07045ff203e50bc9e5277648e3e45f79be4742ff Mon Sep 17 00:00:00 2001 From: JosephABC Date: Thu, 24 Nov 2022 09:15:57 +0800 Subject: [PATCH 2/2] Add default behavior for excludePersistentLag Signed-off-by: JosephABC --- content/docs/2.9/scalers/apache-kafka.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/2.9/scalers/apache-kafka.md b/content/docs/2.9/scalers/apache-kafka.md index f53b5d155..2e3070271 100644 --- a/content/docs/2.9/scalers/apache-kafka.md +++ b/content/docs/2.9/scalers/apache-kafka.md @@ -48,7 +48,7 @@ partitions on a topic, allowing for idle consumers. (Default: `false`, Optional) - `scaleToZeroOnInvalidOffset` - This parameter controls what the scaler does when a partition doesn't have a valid offset. If 'false' (the default), the scaler will keep a single consumer for that partition. Otherwise ('true'), the consumers for that partition will be scaled to zero. See the [discussion](https://github.com/kedacore/keda/issues/2612) about this parameter. -- `excludePersistentLag` - When set to `true`, the scaler will exclude partition lag for partitions which current offset is the same as the current offset of the previous polling cycle. This parameter is useful to prevent scaling due to partitions which current offset message is unable to be consumed. +- `excludePersistentLag` - When set to `true`, the scaler will exclude partition lag for partitions which current offset is the same as the current offset of the previous polling cycle. This parameter is useful to prevent scaling due to partitions which current offset message is unable to be consumed. If `false` (the default), scaler will include all consumer lag in all partitions as per normal. (Default: `false`, Optional) - `version` - Version of your Kafka brokers. See [samara](https://github.com/Shopify/sarama) version (Default: `1.0.0`, Optional) > **Note:**