Skip to content

Commit

Permalink
Add missing TestNamespace to ScaledJob validation test template (#5989)
Browse files Browse the repository at this point in the history
This scaledjob test template was missing its namespace, which doesn't
generally matter for the test -- the test is just checking if the
webhook works, it doesn't care where the scaledjob ends up.

Where it does matter, is if you happen to run this test suite in a more
restrictive environment where you can't write to the default namespace,
because you fail with a namespace-related creation error instead of the
expected "no triggers defined in the ScaledObject/ScaledJob" error.

This just adds the namespace to the template so it's just like all the
other ones in the test suite.

Signed-off-by: John Kyros <jkyros@redhat.com>
  • Loading branch information
jkyros authored Jul 29, 2024
1 parent c740bf0 commit bcdba69
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ apiVersion: keda.sh/v1alpha1
kind: ScaledJob
metadata:
name: {{.EmptyTriggersSjName}}
namespace: {{.TestNamespace}}
spec:
jobTargetRef:
template:
Expand Down

0 comments on commit bcdba69

Please sign in to comment.