Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable scaling without removing object. #1392

Closed
bkruger99 opened this issue Dec 3, 2020 · 5 comments
Closed

Add ability to disable scaling without removing object. #1392

bkruger99 opened this issue Dec 3, 2020 · 5 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@bkruger99
Copy link

Discussion: #1331

With HPA, you can set your deployment (for example) to zero and the HPA won't spin up new pods - disabling the HPA in the process.

What I do like with Keda that I don't want to see go that HPA doesn't allow is exactly the scale to 0 ability for a deployment for example.

Use-Case

We have cases where I work where we backfill some historical data. Currently with regular hpa's, we can leave backfill deployments hanging around and scaled to zero when not in use. When we need to backfill, we can simply scale down our regular workers to zero and scale up our backfill workers. When we're done, we scale backfill back down to zero and then scale up to at least one worker and let hpa handle the rest.

Specification

I really don't have anything to offer here other than this would be something that can be done via least privilege. Add/remove an annotation to scaled object and the metrics server just always returns zero? The hpa object just disappears temporarily? I would like to have an easy toggle for it though. Can an enable/disable value be passed in to the scaled object it itself kinda like replicas? I will defer to expertise in here and I'm curious on the best method for my own future learning.

@bkruger99 bkruger99 added feature-request All issues for new features that have not been committed to needs-discussion labels Dec 3, 2020
@tomkerkhove
Copy link
Member

tomkerkhove commented Dec 3, 2020

Thanks for the report - Feels like there is a lot of overlap with #944 or do you have different needs?

@bkruger99
Copy link
Author

So long as I can disable keda and make changes w/o having to mess with manifest, then yeah, that works. I'll close this one as #944 seems to be the same.

@dmeytin
Copy link

dmeytin commented Jun 6, 2021

+1
We need this feature to support automated DR

@harzallah
Copy link

+1 also for automating DR

@tomkerkhove
Copy link
Member

This is available today in KEDA v2.7: https://keda.sh/docs/2.7/concepts/scaling-deployments/#pause-autoscaling

See #944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
None yet
Development

No branches or pull requests

4 participants