Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global http timeout for manager #1548

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

surki
Copy link
Contributor

@surki surki commented Jan 29, 2021

This was already done in adapter but was missed in manager. Since manager
calls scaler.IsActive() with 0 timeout, it is erring out with "context
deadline exceeded" errors when connection latency is high (like prometheus
scaler trying to contact a prometheus server running in different region)

Signed-off-by: Suresh Kumar Ponnusamy suresh.ponnusamy@freshworks.com

Checklist

This was already done in adapter but was missed in manager. Since manager
calls scaler.IsActive() with 0 timeout, it is erring out with "context
deadline exceeded" errors when connection latency is high (like prometheus
scaler trying to contact a prometheus server running in different region)

Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surki
Copy link
Contributor Author

surki commented Jan 29, 2021

Can you update our deployment YAML (https://github.com/kedacore/keda/blob/main/config/manager/manager.yaml) and

I see that KEDA_HTTP_DEFAULT_TIMEOUT is not set in any manifests (even for keda-metrics-apiserver). Do you want to add for both? And what value do you want to set it to? 3s? (which is the default value if not specified)

open a PR to https://github.com/kedacore/charts please?

It seems there is another PR pending for this kedacore/charts#90
do you want to create a new one, superseding that?

@zroubalik
Copy link
Member

Can you update our deployment YAML (https://github.com/kedacore/keda/blob/main/config/manager/manager.yaml) and

I see that KEDA_HTTP_DEFAULT_TIMEOUT is not set in any manifests (even for keda-metrics-apiserver). Do you want to add for both? And what value do you want to set it to? 3s? (which is the default value if not specified)

open a PR to https://github.com/kedacore/charts please?

my 2c: I don't think that we need to set this to the manifests. If anybody wants to tweak this value, he can add it. But that's not a standard use case, so no need to add complexity over there.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@tomkerkhove
Copy link
Member

Makes sense, sorry for the confusion!

@zroubalik zroubalik merged commit 8d70252 into kedacore:main Jan 29, 2021
ycabrer pushed a commit to ycabrer/keda that referenced this pull request Mar 1, 2021
* Add global http timeout for manager

This was already done in adapter but was missed in manager. Since manager
calls scaler.IsActive() with 0 timeout, it is erring out with "context
deadline exceeded" errors when connection latency is high (like prometheus
scaler trying to contact a prometheus server running in different region)

Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>

* Update changelog

Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Rodolfodc pushed a commit to sidilabs/keda that referenced this pull request Mar 11, 2021
* Add global http timeout for manager

This was already done in adapter but was missed in manager. Since manager
calls scaler.IsActive() with 0 timeout, it is erring out with "context
deadline exceeded" errors when connection latency is high (like prometheus
scaler trying to contact a prometheus server running in different region)

Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>

* Update changelog

Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants