-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global http timeout for manager #1548
Conversation
This was already done in adapter but was missed in manager. Since manager calls scaler.IsActive() with 0 timeout, it is erring out with "context deadline exceeded" errors when connection latency is high (like prometheus scaler trying to contact a prometheus server running in different region) Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update our deployment YAML (https://github.com/kedacore/keda/blob/main/config/manager/manager.yaml) and open a PR to https://github.com/kedacore/charts please?
I see that
It seems there is another PR pending for this kedacore/charts#90 |
my 2c: I don't think that we need to set this to the manifests. If anybody wants to tweak this value, he can add it. But that's not a standard use case, so no need to add complexity over there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
Makes sense, sorry for the confusion! |
* Add global http timeout for manager This was already done in adapter but was missed in manager. Since manager calls scaler.IsActive() with 0 timeout, it is erring out with "context deadline exceeded" errors when connection latency is high (like prometheus scaler trying to contact a prometheus server running in different region) Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com> * Update changelog Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
* Add global http timeout for manager This was already done in adapter but was missed in manager. Since manager calls scaler.IsActive() with 0 timeout, it is erring out with "context deadline exceeded" errors when connection latency is high (like prometheus scaler trying to contact a prometheus server running in different region) Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com> * Update changelog Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
This was already done in adapter but was missed in manager. Since manager
calls scaler.IsActive() with 0 timeout, it is erring out with "context
deadline exceeded" errors when connection latency is high (like prometheus
scaler trying to contact a prometheus server running in different region)
Signed-off-by: Suresh Kumar Ponnusamy suresh.ponnusamy@freshworks.com
Checklist