Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PR authors to run E2E tests. #3004

Closed
v-shenoy opened this issue May 5, 2022 · 3 comments · Fixed by #3033
Closed

Allow PR authors to run E2E tests. #3004

v-shenoy opened this issue May 5, 2022 · 3 comments · Fixed by #3033

Comments

@v-shenoy
Copy link
Contributor

v-shenoy commented May 5, 2022

Right now, only reviewers with write access can trigger e2e tests on a PR. In many cases, the tests work on the developer's local setup, but fail in the KEDA test environment, which can be a bit confusing to debug. This leads to a constant back and forth of the developer making changes, and then having to ask one of the reviewers to run the tests and wait. It is the case, even if the change is as simple as adding a logging statement.

I feel like this process is a bit tedious and can be improved. Wanted to bring this up for a discussion and see if it can be changed.

@tomkerkhove
Copy link
Member

Ha, I'm happy to share that we've already discussed this and we have an improvement coming that would allow more people to trigger e2e tests.

@tomkerkhove tomkerkhove moved this from Proposed to To Do in Roadmap - KEDA Core May 5, 2022
@JorTurFer
Copy link
Member

I expect to have it ready in the beginning of next week
I have a trip for the rest of the week, sorry

@v-shenoy
Copy link
Contributor Author

v-shenoy commented May 5, 2022

@tomkerkhove @JorTurFer Thanks a lot.

And enjoy your trip :)

Repository owner moved this from To Do to Ready To Ship in Roadmap - KEDA Core May 12, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants