Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce metric aggregation/alignment in GCP Stackdriver scaler #3008

Closed
ritmas opened this issue May 5, 2022 · 2 comments · Fixed by #3070
Closed

Introduce metric aggregation/alignment in GCP Stackdriver scaler #3008

ritmas opened this issue May 5, 2022 · 2 comments · Fixed by #3070
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@ritmas
Copy link

ritmas commented May 5, 2022

Proposal

It's crucial to have ability applying aggregation/alignment on GCP Stackdriver metric in order to both fetch less data from GCP API and get exactly what you need.

For instance, aggregator and aligner would be useful:

triggers:
- type: gcp-stackdriver
  metadata:
    projectId: my-project-id
    filter: 'metric.type="loadbalancing.googleapis.com/https/backend_latencies" AND resource.type="https_lb_rule" AND resource.label.forwarding_rule_name="k8s2-..."'
    aggregator: 'mean | sum | 95th_percentile | etc.'
    aligner: 'delta | sum | 95th_percentile | etc.'
    targetValue: '10' # latency in ms
    credentialsFromEnv: GOOGLE_APPLICATION_CREDENTIALS_JSON

Use-Case

No response

Anything else?

No response
@ritmas ritmas added feature-request All issues for new features that have not been committed to needs-discussion labels May 5, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core May 5, 2022
@ritmas
Copy link
Author

ritmas commented May 6, 2022

Is it doable @RamCohen ?

@tomkerkhove tomkerkhove changed the title Aggregation/Alignment on GCP Stackdriver metric Introduce metric aggregation/alignment in GCP Stackdriver scaler May 6, 2022
@RamCohen
Copy link
Contributor

Yes. Working on it

@RamCohen RamCohen mentioned this issue May 25, 2022
Merged
@zroubalik zroubalik moved this from Proposed to In Progress in Roadmap - KEDA Core May 31, 2022
Repository owner moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Jun 29, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GCP stackdriver aggregation parameters RamCohen/keda
2 participants
@RamCohen @ritmas