Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate e2e test for Value metricType to Go #3435

Closed
Tracked by #2737
JorTurFer opened this issue Jul 27, 2022 · 1 comment · Fixed by #3505
Closed
Tracked by #2737

Migrate e2e test for Value metricType to Go #3435

JorTurFer opened this issue Jul 27, 2022 · 1 comment · Fixed by #3505
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@JorTurFer
Copy link
Member

Proposal

Relates to #2357, #2737.

Use-Case

No response

Anything else?

We should port this test to another simpler upstream to check it as internal feature
https://github.com/kedacore/keda/blob/main/tests/scalers/prometheus-value-metric-type.test.ts
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Jul 27, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jul 27, 2022
@JorTurFer JorTurFer mentioned this issue Jul 27, 2022
Closed
48 tasks
@zroubalik
Copy link
Member

zroubalik commented Jul 27, 2022 •
edited
Loading

+1, the tests should probably use Kubernetes Workload Scaler or some similar, that doesn't require addional service.

The current internal e2e tests should be transfered to this simple scaler as well -> tracked here: #3436

@zroubalik zroubalik mentioned this issue Jul 27, 2022
Closed
@JorTurFer JorTurFer moved this from Proposed to To Do in Roadmap - KEDA Core Jul 28, 2022
This was referenced Aug 3, 2022
Merged
Merged
Repository owner moved this from To Do to Ready To Ship in Roadmap - KEDA Core Aug 5, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete e2e test migration. v-shenoy/keda
2 participants
@zroubalik @JorTurFer